[ scummvm-Patches-610251 ] Inappopriate error() exit approach

noreply at sourceforge.net noreply at sourceforge.net
Tue Sep 17 00:52:26 CEST 2002


Patches item #610251, was opened at 2002-09-16 17:52
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=610251&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jamieson Christian (jamieson630)
Assigned to: Nobody/Anonymous (nobody)
Summary: Inappopriate error() exit approach

Initial Comment:
The error() function used far and wide across ScummVM 
attempts to exit the program using exit(1). This type of 
bailout fails to properly shut down supporting systems 
and often results in processor faults (seg fault, page 
fault, etc).

This patch replaces exit(1) with a call to the system 
shutdown function OSystem_SDL_Common::quit().

Note that there are 33 other active occurrences of exit(1) 
within ScummVM, and they may also consitute 
inappropriate bailouts that cause processor faults. It 
may be advisable to review these to see if a cleaner exit 
approach could be applied.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=610251&group_id=37116




More information about the Scummvm-tracker mailing list