[ scummvm-Patches-729365 ] INDY3: Better (but incomomplete) fix for intro costume bug

SourceForge.net noreply at sourceforge.net
Tue Apr 29 08:34:57 CEST 2003


Patches item #729365, was opened at 2003-04-29 08:34
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=729365&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: INDY3: Better (but incomomplete) fix for intro costume bug

Initial Comment:
I've finally figured out why Indy gets the wrong
costume in the Indy3 intro. We already have a hack in
place to correct it, but this patch should be a lot
better, even if it's still slightly incomplete. It also
seems to fix some costume-related bugs at the end of
the game: The bouncing, severed head, and the second
trial, at least. Possibly others as well.

Consider the following script fragments:

script-58.dmp from Passport Demo:

[0022] (AC) Exprmode Var[37] = (9 - Var[118]);
[002D] (2C) InitCharset(1)
[0030] (2C) InitCursor(0)
[0033] (13)
ActorSet(1,[Costume(6),TalkColor(14),Width(16),Name("Indy")]);
[0042] (13)
ActorSet(4,[Costume(4),Unknown(74),TalkColor(7),Width(16),Name("Marcus"),Elevation(-1)]);

script-118.dmp from Indy3:

[0022] (AC) Exprmode Var[37] = (9 - Var[66]);
[002D] (2C)
CursorCommand([11265,4864,2561,3611,4114,28233,121])
[0045] (13)
ActorSet(4,[Costume(6),Unknown(1),TalkColor(7),Width(16),Name("Marcus"),Elevation(-1)]);

Since the Passport Demo works just fine, it becomes
pretty clear that the CursorCommand opcode is handled
incorrectly. This is what it'd look like after the patch:

[0022] (AC) Exprmode Var[37] = (9 - Var[66]);
[002D] (2C) UnkCursorCommand14(1,1)
[0031] (2C) InitCursor(0)
[0034] (13)
ActorSet(1,[Costume(10),Unknown(27),TalkColor(14),Width(16),Name("Indy")]);
[0045] (13)
ActorSet(4,[Costume(6),Unknown(1),TalkColor(7),Width(16),Name("Marcus"),Elevation(-1)]);

I don't know what CursorCommand, subopcode 14 should
really do. Something about the charset probably, but
I'm not sure what.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=729365&group_id=37116




More information about the Scummvm-tracker mailing list