[ scummvm-Bugs-782132 ] -e null doesn't work

SourceForge.net noreply at sourceforge.net
Sun Aug 3 01:20:06 CEST 2003


Bugs item #782132, was opened at 2003-08-03 01:20
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=782132&group_id=37116

Category: iMuse/Music
Group: Monkey Island 1
Status: Open
Resolution: None
Priority: 5
Submitted By: Uwe Ryssel (uweryssel)
Assigned to: Nobody/Anonymous (nobody)
Summary: -e null doesn't work

Initial Comment:
The "-e null" option doesn't work with monkeyvga.
Although I switched off the music, it is still playing.

I looked into the sources and found the cause in gameDetector.cpp line 663
in "int GameDetector::detectMain()":

    /* Use the adlib sound driver if auto mode is selected,
     * and the game is one of those that want adlib as
     * default, OR if the game is an older game that doesn't
     * support anything else anyway. */
    if ((_game.adlib & VersionSettings::ADLIB_ALWAYS) ||
       ((_game.adlib & VersionSettings::ADLIB_PREFERRED) && _midi_driver == MD_AUTO)) {
        _midi_driver = MD_ADLIB;
        _use_adlib = true;
    }

ADLIB_ALWAYS is set in case of monkeyvga, so MD_ADLIB overwrites MD_NULL.

A solution is:

    if ((_game.adlib & VersionSettings::ADLIB_ALWAYS) && _midi_driver != MD_NULL ||
       ((_game.adlib & VersionSettings::ADLIB_PREFERRED) && _midi_driver == MD_AUTO)) {
        _midi_driver = MD_ADLIB;
        _use_adlib = true;
    }
              
My version is ScummVM 0.5.0.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=782132&group_id=37116




More information about the Scummvm-tracker mailing list