[ scummvm-Patches-858731 ] GUI::OptionsDialog base class calls under MSVC6

SourceForge.net noreply at sourceforge.net
Fri Dec 12 07:07:24 CET 2003


Patches item #858731, was opened at 2003-12-12 00:07
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=858731&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jamieson Christian (jamieson630)
Assigned to: Max Horn (fingolfin)
Summary: GUI::OptionsDialog base class calls under MSVC6

Initial Comment:
The attached patch works around MSVC6's difficulties 
with the notation of explicit base class function calls in 
cases where the namespace of the base class is 
different than that of the derived class. Specifically, the 
patch is meant to correct [erroneous] compile-time 
errors related to calls made by Scumm::OptionsDialog to 
base class GUI::OptionsDialog methods of the same 
name. The trouble functions are open(), close() and 
handleCommand().

The patch creates "internal" versions of the necessary 
base class methods and puts the actual implementation 
there. The override functions just call the internal 
methods. In this way, the derived class can also call the 
base class implementation by using the internal methods, 
and thus avoid a name ambiguity.

This definitely muddies up the code a bit, and I'm not 
happy with that because we could find ourselves having 
to do in a variety of situations in the future, given our 
new namespace design. Any other ideas? Is this where 
we need to throw in the towel and abandon MSVC6 
support entirely? :-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=858731&group_id=37116




More information about the Scummvm-tracker mailing list