[ scummvm-Simon Bugs-1004919 ] Simon sound code causes lockup

[SourceForge.net]

Simon Bugs item #1004919, was opened at 2004-08-06 23:01
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=516929&aid=1004919&group_id=37116

Category: Unknown Crash/Other
Group: Simon The Sorcerer 1
Status: Open
Resolution: None
Priority: 5
Submitted By: Lars Persson (anotherguest)
Assigned to: Nobody/Anonymous (nobody)
Summary: Simon sound code causes lockup

Initial Comment:
In this function the Midiplayer locks the mutex, and then 
setLoop wants to lock it again. Result.. lockup. 
Suggested fix.. release mutex lock.. and lockit after 
setLoop has been made.

void MidiPlayer::loadSMF (File *in, int song, bool sfx) {
{
 _system->lock_mutex(_mutex);

.
.
.
Before
 if (!sfx)
	setLoop(p->data[6] != 0);

should be 
if (!sfx)
 {
	_system->unlock_mutex (_mutex);
	setLoop (p->data[6] != 0);
	_system->lock_mutex (_mutex);
 }



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=516929&aid=1004919&group_id=37116