[ scummvm-Patches-878883 ] Fix for Ogg Vorbis playback in BS2 cutscenes

[SourceForge.net]

Patches item #878883, was opened at 2004-01-17 16:47
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=878883&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for Ogg Vorbis playback in BS2 cutscenes

Initial Comment:
I've been having trouble with the Ogg Vorbis playback
in the BS2 cutscenes. I finally sat down and tried to
figure out what happened:

readBuffer() is called with 11024 being the desired
number of samples.

On the first iteration, samples is 0 and _bufferEnd -
_pos is 4096. Since this is less than 11024, len gets
set to 4096.

On the second iteration, samples is 4096, and
_bufferEnd - _pos is still 4096. Since 4096 + 4096 =
8192 is still less than 11024, len gets set to 8192.

At this stage, we have copied 4096 + 8192 = 12288
samples, which seems like a major whoops to me.

I don't know if this patch is correct (I'm still
fighting off the onset of a cold, which doesn't help my
thinking :-), but it does fix the crashing problem for me.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=878883&group_id=37116