[ scummvm-Bugs-1098872 ] Memoryleak in SMUSH player

[SourceForge.net]

Bugs item #1098872, was opened at 2005-01-09 11:59
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1098872&group_id=37116

Category: Insane/Smush
Group: All Games
Status: Open
Resolution: None
Priority: 5
Submitted By: Lars Persson (anotherguest)
Assigned to: Eugene Sandulenko (sev)
Summary: Memoryleak in SMUSH player

Initial Comment:
In a couple places in the smush_player.cpp a special 
buffer is created when the videoheight & width is 
242x384. But no check is made to see if the 
_specialBuffer already has been allocated. I think it 
should look like this

if ((height == 242) && (width == 384)) {
if(_specialBuffer == NULL)
 _specialBuffer = (byte *)malloc(242 * 384);
 _dst = _specialBuffer;
} else if ((height > _vm->_screenHeight) || (width > 
_vm->
...

instead of

if ((height == 242) && (width == 384)) {
_dst = _specialBuffer = (byte *)malloc(242 * 384);
}
else
...




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1098872&group_id=37116