[ scummvm-Bugs-1231434 ] MIDI: SysEx API is not used consistently

[SourceForge.net]

Bugs item #1231434, was opened at 2005-07-02 12:31
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1231434&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: iMuse/Music
Group: All Games
Status: Open
Resolution: None
Priority: 5
Submitted By: Max Horn (fingolfin)
Assigned to: Nobody/Anonymous (nobody)
Summary: MIDI: SysEx API is not used consistently

Initial Comment:
Our MidiDriver::sysEx() method is not used consistently; I
guess that's partially because it's not really clearly
documented (we should fix that, once we have determined
*what* it should do, precisely :-).

Right now, most of our MidiDrivers (but not all) expect
sysEx() to receive sysEx data w/o the leading 0xF0 and the
trailing 0xF7.

Some of the client code complies to that; but there are
other places where we call sysEx with data which already
includes the 0xF0 / 0xF7.

So, we should decide which behaviour we prefer. Once we have
done that, we should fix all MidiDrivers and all places
where sysEx() is called to comply to that specification. And
of course it should also be documented in a doxygen commen
in mididriver.h!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1231434&group_id=37116