[ scummvm-Bugs-1210836 ] ALL: Failed assertion in AdvMame scaler

SourceForge.net noreply at sourceforge.net
Sun May 29 17:35:41 CEST 2005


Bugs item #1210836, was opened at 2005-05-29 17:35
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1210836&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: All Games
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: ALL: Failed assertion in AdvMame scaler

Initial Comment:
Latest ScummVM CVS snapshot

Twice in the last two days, ScummVM has crashed on the
following assertion:

Failed assertion in common/scaler/scalebit.cpp

scummvm: common/scaler/scalebit.cpp:118: void
scale2x(void*, unsigned int, const void*, unsigned int,
unsigned int, unsigned int, unsigned int): Assertion
'height >= 2' failed.

The first time it happened was with Sam & Max, I think.
The second time was with Maniac Mansion.

As far as I could tell, it happened during a normal
screen update. The simplest explanation, then, would be
that it was trying to scale a rectangle that was either
0 or 1 pixels tall.

The addDirtyRect() function is called from:

* addDirtyRgnAuto()
* copyRectToOverlay()
* copyRectToScreen()
* drawMouse()
* undrawMouse()

It can't have been addDirtyRgnAuto(). As far as I know
only the Simon games use it, and the smallest region it
ever dirties is 8x8.

It can't have been copyRectToOverlay(). It was during
normal gameplay. And if it was, that function behaves
pretty much like copyRectToScreen() when it comes to
screen dirtying.

I don't think it could have been copyRectToScreen().
The smallest rectangle it ever dirties is 1x1, and
since addDirtyRect() extends the dirty region by one
pixel in each direction (unless mouseRect is true),
even after re-clipping the rectangle would be at least
2x2 pixels.

It's tempting to blame drawMouse() or undrawMouse(),
but I just don't know.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1210836&group_id=37116




More information about the Scummvm-tracker mailing list