[ scummvm-Bugs-1520629 ] No Music in Simon1

[SourceForge.net]

Bugs item #1520629, was opened at 2006-07-11 17:56
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1520629&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: iMuse/Music
Group: Simon The Sorcerer 1 (WIN)
Status: Open
Resolution: None
Priority: 5
Submitted By: athrxx (athrxx)
Assigned to: Nobody/Anonymous (nobody)
Summary: No Music in Simon1

Initial Comment:
I don't know if I am the only one who encountered this,
but when compiling with Visual C++ 7.1 and turning on
optimizations (one or more of /O1 /O2 /Ox, /Og) the
midi music in Simon 1 won't play (Simon 2 works fine).

The offending lines are lines 482 and 489 in
simon\midi.cpp. The problem seems to be the order in
which the methods that are passed as arguments are called.

Changing both lines from

in->seek(in->readUint32BE() + in->pos(), SEEK_SET);

to

uint32 offset = in->readUint32BE();
in->seek(offset + in->pos(), SEEK_SET);

solves the problem.
The uint32 should obviously be declared only once.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1520629&group_id=37116