[ scummvm-Patches-1701058 ] Correct some graphical glitches for Brocken Sword 1 Mac

[SourceForge.net]

Patches item #1701058, was opened at 2007-04-15 16:40
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1701058&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thierry Crozat (criezy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Correct some graphical glitches for Brocken Sword 1 Mac

Initial Comment:
In several screen there were graphical glitches with the original patch for BS1 Mac support (see this patch submission for snapshots). These come from the fact that the mac version of BS1 uses the last color of the palette for the background while the PC version uses the first color of the palette. Consequently, there were two parts in the code that needed to be adapted (both in engines/sword1/screen.cpp):

In Screen::fnSetPalette(), in addation to setting the first color to black, I am also setting the last one to black. I am not sure of this. Maybe it would be better to set either the firt one or the last one to black depending on the BS1 version instead of setting both colors to black.

In Screen::draw(), for the screen 54 (Syria, outside of the cave) a background parallax layer is used and then the _layerBlcoks[0] is written above for the blocks that do not use the background color (0 or 255, while only 0 was tested). Here again, I am not sure if we should test for both 0 and 255 or only one of them depending on the BS1 version.

This patch works fine with the mac version, but should be tested with the PC versions, especially in the screens 10 and 78 (Nico's flat in Paris and final scene in scotland before the tower is blown apart, where we see this background color) and of course screen 54. I can provide save games for all three locations if needed.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1701058&group_id=37116