[ scummvm-Patches-1822349 ] Refactor engines handling in configure script
SourceForge.net
noreply at sourceforge.net
Mon Oct 29 21:32:20 CET 2007
Patches item #1822349, was opened at 2007-10-29 21:32
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1822349&group_id=37116
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jordi Vilalta (jvprat)
Assigned to: Nobody/Anonymous (nobody)
Summary: Refactor engines handling in configure script
Initial Comment:
After seeing the added "Engines Skipped" listing, it made me think about the current hardcoded handling of engines in the configure script.
The attached patch refactors it so all the information about an engine is compacted in a small array of variables and then this information is used wherever it's needed in a generalized way.
This could also be used to dynamically generate the engine information in engines/engines.mk and base/plugins.cpp, but I remember Fingolfin said some ports don't use the configure script... Maybe the engine information could be extracted outside the configure script to make it even more general? If there's interest on this I could try to work on it.
Again, this eases the maintenance of out-of-trunk engines, having just to mantain the engine information array.
This approach uses evaluation of variables with dynamic names. I've tried it with bash and busybox's ash, but I don't know if I'm using some shell specifics that could cause troubles in other shells and reduce portability.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1822349&group_id=37116
More information about the Scummvm-tracker
mailing list