[ scummvm-Patches-2019455 ] Patch for reducing the BSS size of Cine engine

[SourceForge.net]

Patches item #2019455, was opened at 2008-07-16 15:22
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2019455&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Kari Salminen (buddha_)
Assigned to: Eugene Sandulenko (sev)
Summary: Patch for reducing the BSS size of Cine engine

Initial Comment:
Here's a patch to reduce the BSS size of the Cine engine
(There's been talk about reducing the BSS size of the
engines on the mailing list recently). Didn't know if I
should just commit this straight to the trunk as the
trunk's in code freeze at the moment so took the more
cautious approach of making it a patch.

I just encapsulated the 64kB global array textTable into
a struct and made an instance of that struct to be a
member variable of the CineEngine class. That should
make it to be allocated from the heap. I know the
solution isn't maybe the cleanest of approaches, but I
think it is 1) easy, 2) not error prone, 3) small. So
IMO any possibility of regressions is extremely small.

NOTE: The patch uses bytes 0x0d, 0x0a as the newline
convention.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2019455&group_id=37116