[ scummvm-Patches-2357165 ] Custom percussion instruments for the AdLib MIDI driver

[SourceForge.net]

Patches item #2357165, was opened at 2008-11-29 00:33
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2357165&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jordi Vilalta Prat (jvprat)
Assigned to: Nobody/Anonymous (nobody)
Summary: Custom percussion instruments for the AdLib MIDI driver

Initial Comment:
The attached patch adds custom instruments support to the AdLib MIDI driver. It lets the Groovie engine to play the AdLib music properly without having to use the FMOPL driver directly. I've used 'ADLP' as the sysex type, adding P for percussion to the standard AdLib instruments (I guess that's an internal constant). With this each key can be associated to an AdLib instrument definition and the absolute note that should be played.

In addition, the patch removes the empty implementation of AdlibPercussionChannel::controlChange(), which lets the volume to be set properly for the percussion channel. If the other controls need to be ignored, a personalized implementation could be done.

I'm submitting it to the tracker because it's my first time with AdLib instruments and I don't know whether this approach is good enough, or maybe it should be changed to a more general solution. Thanks in advance to any reviews.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2357165&group_id=37116