[ scummvm-Bugs-2101083 ] ANY - MSVC71 compilation fails due to warnings-as-errors

[SourceForge.net]

Bugs item #2101083, was opened at 2008-09-08 18:32
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2101083&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Quietust (quietust)
Assigned to: Nobody/Anonymous (nobody)
Summary: ANY - MSVC71 compilation fails due to warnings-as-errors

Initial Comment:
As a result of commit 34447 (which enables "treat warnings as errors" for all projects), Parallaction and Queen no longer compile in MSVC71 (and likely MSVC70 as well).

\scummvm\scummvm\engines\queen\journal.cpp(398) : error C2220: warning treated as error - no object file generated
\scummvm\scummvm\engines\queen\journal.cpp(398) : warning C4258: 'p' : definition from the for loop is ignored; the definition from the enclosing scope is used
(...)

\scummvm\scummvm\engines\parallaction\gui_br.cpp(234) : error C2220: warning treated as error - no object file generated
\scummvm\scummvm\engines\parallaction\gui_br.cpp(234) : warning C4258: 'i' : definition from the for loop is ignored; the definition from the enclosing scope is used
(...)

Considering the warnings just report what is probably intended behavior, it would probably be safe to simply ignore that warning rather than try to reorder the code to make it go away.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2101083&group_id=37116