[ scummvm-Patches-2671477 ] Buffer Overflow

[SourceForge.net]

Patches item #2671477, was opened at 2009-03-07 14:20
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2671477&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Felipe Lotas (reddwarf69)
Assigned to: Nobody/Anonymous (nobody)
Summary: Buffer Overflow

Initial Comment:
>From openSUSE rpmlint...
I: Statement might be overflowing a buffer in strncat. Common mistake:
   BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over size as 3rd argument
   GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1)
E: scummvm bufferoverflowstrncat engines/saga/sfuncs.cpp:1573
E: scummvm bufferoverflowstrncat engines/scumm/he/logic_he.cpp:89


No especially efficient (too much strlen()) but fixes the problem.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2671477&group_id=37116