[ scummvm-Bugs-2980384 ] LURE: Valgrind Memory Errors When Skorl Gatekeeper Drinks

[SourceForge.net]

Bugs item #2980384, was opened at 2010-04-01 05:21
Message generated for change (Tracker Item Submitted) made by tdhs
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2980384&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: Lure of the Temptress
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Turner (tdhs)
Assigned to: Paul Gilbert (dreammaster)
Summary: LURE: Valgrind Memory Errors When Skorl Gatekeeper Drinks

Initial Comment:
When the Skorl Gatekeeper lays down to drink from the cask, Valgrind indicates a number of memory errors associated with hotspots.
The console also issues the following warnings:
WARNING: Hotspot 2725h is not currently active!
WARNING: Hotspot 2726h is not currently active!

This is repeatable and is triggered by the following procedure:
1. Load Savegame
2. (Quickly) Use Tongs on Bung (in Cask)
3. Talk to Minnow (before he leaves room)
    - Am here for Selena
    - Tell Skorl that Cask is Leaking
4. Hide behind back right Pillar
5. Wait. Skorl Guard comes in, sees leaking cask and drinks. Error occurs.

Valgrind output is as follows :
==9090== Thread 1:
==9090== Invalid read of size 2
==9090==    at 0x850847E: Lure::Hotspot::doAction(Lure::Action, Lure::HotspotData*) (hotspots.cpp:1368)
==9090==    by 0x85093FC: Lure::Hotspot::doAction() (hotspots.cpp:1239)
==9090==    by 0x8509CF8: Lure::HotspotTickHandlers::standardCharacterAnimHandler(Lure::Hotspot&) (hotspots.cpp:2645)
==9090==    by 0x850A5DF: Lure::HotspotTickHandlers::jailorAnimHandler(Lure::Hotspot&) (hotspots.cpp:3208)
==9090==    by 0x84FDE11: Lure::Hotspot::tick() (hotspots.cpp:477)
==9090==    by 0x84FC1E4: Lure::Game::tick() (game.cpp:92)
==9090==    by 0x84FC28B: Lure::Game::nextFrame() (game.cpp:125)
==9090==    by 0x84FC536: Lure::Game::execute() (game.cpp:182)
==9090==    by 0x84CF21F: Lure::LureEngine::go() (lure.cpp:160)
==9090==    by 0x84D03B4: Lure::LureEngine::run() (lure.h:102)
==9090==    by 0x80565C0: runGame(PluginSubclass<MetaEngine> const*, OSystem&, Common::String const&) (main.cpp:216)
==9090==    by 0x8056F69: scummvm_main (main.cpp:389)
==9090==  Address 0x611748c is 36 bytes inside a block of size 2,492 free'd
==9090==    at 0x4024D9A: operator delete(void*) (in /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so)
==9090==    by 0x84DAA45: Common::SharedPtrDeletionImpl<Lure::Hotspot>::~SharedPtrDeletionImpl() (ptr.h:48)
==9090==    by 0x84D02B8: Common::SharedPtr<Lure::Hotspot>::decRef() (ptr.h:206)
==9090==    by 0x84D02E8: Common::SharedPtr<Lure::Hotspot>::~SharedPtr() (ptr.h:122)
==9090==    by 0x84D02FF: Common::ListInternal::Node<Common::SharedPtr<Lure::Hotspot> >::~Node() (list_intern.h:42)
==9090==    by 0x84D739B: Common::List<Common::SharedPtr<Lure::Hotspot> >::erase(Common::ListInternal::NodeBase*) (list.h:241)
==9090==    by 0x84D741E: Common::List<Common::SharedPtr<Lure::Hotspot> >::erase(Common::ListInternal::Iterator<Common::SharedPtr<Lure::Hotspot> >) (list.h:88)
==9090==    by 0x84D3411: Lure::Resources::deactivateHotspot(unsigned short, bool) (res.cpp:680)
==9090==    by 0x84E9539: Lure::Script::deactivateHotspot(unsigned short, unsigned short, unsigned short) (scripts.cpp:136)
==9090==    by 0x84EA306: Lure::Script::execute(unsigned short) (scripts.cpp:1110)
==9090==    by 0x8500EE1: Lure::Hotspot::npcExecScript(Lure::HotspotData*) (hotspots.cpp:2056)
==9090==    by 0x8508366: Lure::Hotspot::doAction(Lure::Action, Lure::HotspotData*) (hotspots.cpp:1330)

ScummVM 1.2.0svn48453 (Apr  1 2010 03:32:24)
Features compiled in: Vorbis FLAC MP3 ALSA RGB zLib FluidSynth
built on Linux x86_32 2.6.31 by GCC 4.3.4

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2980384&group_id=37116