[ scummvm-Patches-2980691 ] GSoC: GUI: Caret blink shaves pixels [...] (bug #2951681)

[SourceForge.net]

Patches item #2980691, was opened at 2010-04-01 15:53
Message generated for change (Tracker Item Submitted) made by vgvgf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2980691&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: GSoC
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: vgvgf (vgvgf)
Assigned to: Nobody/Anonymous (nobody)
Summary: GSoC: GUI: Caret blink shaves pixels [...] (bug #2951681)

Initial Comment:
Proposed patch for bug number 2951681 "GUI: Caret blink shaves pixels from the letter underneath"

The problem is in ThemeEngine::drawCaret and EditableWidget::drawCaret.
When erasing the cursor caret, ThemeEngine::drawCaret only restores the
background of the widget but not the character that was affected by the cursor.

My proposed solution is to draw again the char affected by the cursor in
EditableWidget::drawCaret when erasing the cursor. This way the
text is restored when the cursor blinks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2980691&group_id=37116