[ scummvm-Patches-3049421 ] descumm: better string output and semicolon cleanup for

[SourceForge.net]

Patches item #3049421, was opened at 2010-08-21 01:26
Message generated for change (Tracker Item Submitted) made by jestar_jokin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3049421&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Laurence Dougal Myers (jestar_jokin)
Assigned to: Nobody/Anonymous (nobody)
Summary: descumm: better string output and semicolon cleanup for

Initial Comment:
This patch comprises of fixes for two issues:

1) descumm is outputting semicolons in odd places for SCUMM <= V5 scripts.
 - doSentence is missing semicolons when outputting special values "STOP" and "RESET"
 - setVarRange is outputting semicolons in the middle of the instruction
 - drawBox is outputting semicolons in the middle of the instruction

2) Improved and standardised string output.
The string output method has been consolidated into descumm-common.cpp, and is now shared between all SCUMM versions (except HE games, and possibly low SCUMM versions, but tested against V5 and V6). In addition, extra information is now output for some in-line string functions, and the formatting of the string functions and how they join with the rest of the string has been changed. For example, an old string might look like this:

talkActor(:sound:"It makes me feel GREAT!":wait:"Smarter!  More aggressive!",7)

new version:

talkActor(sound(0x3BD5, 0x16) + "It makes me feel GREAT!" + wait() + "Smarter!  More aggressive!",7)

HE string output has not been changed. I've added an extra workaround for Indy3 scripts (gleaned from the main ScummVM source).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3049421&group_id=37116