[ scummvm-Bugs-2943361 ] Regression in numpad handling

[SourceForge.net]

Bugs item #2943361, was opened at 2010-01-31 15:14
Message generated for change (Tracker Item Submitted) made by littleboy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2943361&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: GUI
Group: Unknown
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Julien (littleboy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Regression in numpad handling

Initial Comment:
r46808 introduced support for keypad direction keys to SCI and the GUI.

Since SCI has its own event handler that tracks all needed modifier keys (including num lock) and keeps the flag states internally, it works properly in games (see SciEvent::getFromScummVM() in sci/event.cpp:104)

But the patch also changed the GUI widgets event handlers and then now handle the keypad keys as if numlock was pressed all the time, even though the sdl backend never checks for that particular modifier key (see SDLModToOSystemKeyFlags(SDLMod mod) in backends/platform/sdl/events.cpp:155)

This can be seen by trying to input values from the keypad in the editable widgets (or in the debugger console).

I'm going to try to come up with a patch for sticky-key support, so that the SCI engine-specific code can be modified to rely on the common event code.In the meantime, would it be possible to revert all the non-SCI changes in r46808, since it breaks the console and all editable widgets (including the savegame dialog).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2943361&group_id=37116