[ scummvm-Bugs-3116614 ] MIDI channel aftertouch ignored in SCI (patch inside)

[SourceForge.net]

Bugs item #3116614, was opened at 2010-11-23 23:16
Message generated for change (Tracker Item Submitted) made by sven3000
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3116614&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: iMuse/Music
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Sven (sven3000)
Assigned to: Nobody/Anonymous (nobody)
Summary: MIDI channel aftertouch ignored in SCI (patch inside)

Initial Comment:
In King's Quest 4 SCI, I repeatedly encountered the message "WARNING: Ignoring MIDI event d0". This MIDI command is the MIDI "channel aftertouch" message, and for some reason it is ignored by the SCI MIDI driver. This is because "case 0xd0" is not handled in the MidiPlayer_Midi::send function.

Although I have only seen this problem in KQ4 so far, I suppose it could occur in any SCI game that uses the channel aftertouch messages.

Attached is a patch that fixes this issue. It simply forwards the channel aftertouch messages to the driver as is. Further testing might be needed to see if this cause any side-effects.

This issue was observed on ScummVM 1.2 and 1.3svn54422 on Windows 7 x64, with game versions 1.000.111 and 1.006.004.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3116614&group_id=37116