[ scummvm-Bugs-3117434 ] MT-32 reverb config parsed incorrectly

SourceForge.net noreply at sourceforge.net
Wed Nov 24 10:10:41 CET 2010


Bugs item #3117434, was opened at 2010-11-24 18:10
Message generated for change (Tracker Item Submitted) made by sven3000
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3117434&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: iMuse/Music
Group: SCI: King's Quest IV
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Sven (sven3000)
Assigned to: Nobody/Anonymous (nobody)
Summary: MT-32 reverb config parsed incorrectly

Initial Comment:
ScummVM doesn't correctly parse the reverb data in the MT-32 patch resource. It also doesn't send the default reverb settings to the MT-32. This problem seems to apply to every SCI0 and SCI1 game.

In the MidiPlayer_Midi::readMt32Patch (engines/sci/sound/driver/midi.cpp) function, the _reverbConfig array is initialized in the wrong order. It is read row-wise while it is stored column-wise. The attached patch includes a fix for this function.

In addition, the reverb settings stored in _reverbConfig[0] need to be sent to the MT-32 somewhere. The real SCI engine (observed by running the games in DOSBox) sends this command before it first plays music.

I think the best place to put it would probably be MidiParser_SCI::sendInitCommands (engines/sci/sound/midiparser_sci.cpp), but that seems to send it more often than the real SCI does. If you know a better place to put it, be my guest.

Because I wasn't sure where to put it, the attached patch does NOT include this! It only fixes the reverb config parsing!

This behaviour was observed with ScummVM 1.2.0 and svn revision 54451, on Windows 7 x64, and with multiple games including KQ4 and KQ5.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3117434&group_id=37116




More information about the Scummvm-tracker mailing list