[ scummvm-Bugs-3291522 ] WARNING: No error!

SourceForge.net noreply at sourceforge.net
Fri Apr 22 18:50:30 CEST 2011


Bugs item #3291522, was opened at 2011-04-22 16:50
Message generated for change (Tracker Item Submitted) made by vcappe
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3291522&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Vincent Cappe (vcappe)
Assigned to: Nobody/Anonymous (nobody)
Summary: WARNING: No error!

Initial Comment:
Since commit 3a57419; commands that do nothing but print some info on stdout  and exit (e.g -v, -t, -z), will also print a 'WARNING: No error' on stderr. In base/main.cpp:

@@ -352,8 +351,10 @@ extern "C" int scummvm_main(int argc, const char * const argv[]) {
 
        // TODO: deal with settings that require plugins to be loaded
        res = Base::processSettings(command, settings);
-       if (res.getCode() != Common::kArgumentNotProcessed)
+       if (res.getCode() != Common::kArgumentNotProcessed) {
+               warning("%s", res.getDesc().c_str());
                return res.getCode();
+       }

iiuc, the warning should really only happen if (res.getCode() != Common::kNoError). (but the return still need to happen when res.getCode() is kNoError; kNoError here means that it was a command-line only command and that we are done).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3291522&group_id=37116




More information about the Scummvm-tracker mailing list