[ scummvm-Patches-3298149 ] AGI: Convert preagi_winnie macros to inline functions
SourceForge.net
noreply at sourceforge.net
Fri May 6 06:28:41 CEST 2011
Patches item #3298149, was opened at 2011-05-06 04:28
Message generated for change (Tracker Item Submitted) made by
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3298149&group_id=37116
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: AGI: Convert preagi_winnie macros to inline functions
Initial Comment:
preagi_winnie.cpp uses macros to inline two functions, "setTakeDrop()" and "makeSel()". In C++ I believe it's considered proper to do this is with real inline functions. setTakeDrop also seems to use too much code for what it needs to do.
This trivial patch replaces the two #defines with inline functions, and simplifies setTakeDrop. It was tested with MinGW on Windows 7.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3298149&group_id=37116
More information about the Scummvm-tracker
mailing list