[Scummvm-tracker] [ScummVM] #9841: SCI: KQ6: No credits music

[Colin Snover]

#9841: SCI: KQ6: No credits music
-----------------------------+-------------------------
  Reporter:  dafioram        |      Owner:  csnover
      Type:  defect          |     Status:  closed
  Priority:  normal          |  Component:  Engine: SCI
Resolution:  wontfix         |   Keywords:
      Game:  King's Quest 6  |
-----------------------------+-------------------------
Changes (by csnover):

 * owner:  (none) => csnover
 * status:  new => closed
 * resolution:   => wontfix


Comment:

 > Then I put a misc track01.ogg into the folder and it played the audio,
 but still gives the "Failed to query the CD TOC: 21" in the status window
 (see FailTOC.png). So as long as i can get the track it works and now it
 just reports a disc query error.

 This is a debugging message, not a warning/error. You may ignore it.


 > Maybe it shouldn't query the disc if it finds the track in the folder?

 Since `Win32AudioCDManager::play` prefers emulated CD (and so does the
 MacOSXAudioCDManager), the CD manager code could be changed so that
 AudioCDManager tries to open the real CD itself in `play` after emulation
 fails, instead of right now where users of AudioCDManager must call `open`
 themselves before they can call `play` (and then the result of that `open`
 is ignored anyway if emulated files are available). I do not know the
 reason why `open` is its own public API. (If it is because the engine is
 responsible for cleaning up also with `close`, then I guess SCI is leaking
 resources right now when CD audio tries to be played…)


 > Any idea how many tracks it is looking for?

 It is not looking for more than one track; querying the CD TOC tells the
 manager how many tracks are available on the CD.


 > Do you know if the GOG version has the audio tracks?

 [https://www.gog.com/forum/kings_quest_series/kings_quest_vi_girl_in_the_tower_song
 It apparently does not].


 > The track is supposed to be called track1.mp3 / .ogg

 Tracks with leading zeroes are supported just fine.


 > And I'm not sure if ogg support is built into daily builds, probably it
 is, but I'm not sure.

 Yes, it is. (Per the earlier comment, audio from a random track01.ogg
 played successfully.)

 So I will close this ticket now since the root problem is that KQ
 Collection doesn’t include the CD audio track. If someone wants to have
 the audio CD manager changed to avoid loading CDs unnecessarily as
 described above, please go ahead and open a new ticket for that.

--
Ticket URL: <https://bugs.scummvm.org/ticket/9841#comment:6>
ScummVM <https://bugs.scummvm.org>
ScummVM