[Scummvm-tracker] [ScummVM] #9717: GUI: Indirectly changing 'GUI Language' can produce inconsistent behaviour when changing some options.

[Thierry Crozat]

#9717: GUI: Indirectly changing 'GUI Language' can produce inconsistent behaviour
when changing some options.
---------------------+--------------------
  Reporter:  macca8  |      Owner:  (none)
      Type:  defect  |     Status:  new
  Priority:  low     |  Component:  GUI
Resolution:          |   Keywords:
      Game:          |
---------------------+--------------------

Comment (by criezy):

 You mean on GitHub I suppose
 (https://github.com/scummvm/scummvm/blob/master/gui/options.cpp#L1905)? It
 does indeed look like it has some issues parsing this code. But I think
 that this issue is with the display on GitHub, not with the code.

 Regarding your reported issue, I can indeed reproduce it (and thank you
 for reporting it!). I think there are actually two issues here:

 1. The first one is similar to bug #9711. Changes of the GUI language
 triggers a rebuild of the GUI. As such any setting changed but not not yet
 applied when applying the language change may be lost. Bug #9711 was fixed
 by moving the language change apply to after applying all other changes in
 GlobalOptionsDialog, but before applying the changes of the OptionsDialog.
 Thus settings common to the global options and game options, such as
 graphics settings, may be lost when we also change the language at the
 same time.

 To reproduce 1, change the language and toggle on/off the "Filter
 graphics" button. When you apply the change stye language is change but
 the Filter graphics options is reverted back to its original value. The
 same happen with other options (such as changing the  Fullscreen mode and
 language at the same time).

 2. The second issue is that the <default>language setting appear to not be
 handled correctly resulting in a change to the language setting when we
 would not expect it. And this in turn triggers the first issue.

--
Ticket URL: <https://bugs.scummvm.org/ticket/9717#comment:4>
ScummVM <https://bugs.scummvm.org>
ScummVM