[Scummvm-tracker] [ScummVM] #9717: GUI: Indirectly changing 'GUI Language' can produce inconsistent behaviour when changing some options.

macca8 trac at scummvm.org
Thu Mar 23 07:50:29 CET 2017


#9717: GUI: Indirectly changing 'GUI Language' can produce inconsistent behaviour
when changing some options.
---------------------+--------------------
  Reporter:  macca8  |      Owner:  (none)
      Type:  defect  |     Status:  new
  Priority:  low     |  Component:  GUI
Resolution:          |   Keywords:
      Game:          |
---------------------+--------------------

Comment (by macca8):

 Criezy, regarding the incorrect handling of the <default> language setting
 that you identified above, I've noted your comments in PR 921, in
 particular the handling of an empty string (the <default> equivalent).

 Your comprehensive analysis suggests a simple solution to resolve this.

 Add the following code as the opening statement to the definition of
 TranslationManager::parseLanguage(string &lang).

         if (lang.empty())
         return kTranslationAutodetectId;


 I may be over simplifying things, but if you consider it viable, please
 feel free to commit this change.

--
Ticket URL: <https://bugs.scummvm.org/ticket/9717#comment:8>
ScummVM <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list