[Scummvm-tracker] [ScummVM] #9764: SCI: Multiple games assertion failures in resource_audio.cpp
Colin Snover
trac at scummvm.org
Wed May 10 07:51:43 CEST 2017
#9764: SCI: Multiple games assertion failures in resource_audio.cpp
-----------------------+-------------------------
Reporter: Laylia27 | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: Engine: SCI
Resolution: | Keywords:
Game: |
-----------------------+-------------------------
Changes (by csnover):
* priority: high => normal
* game: EcoQuest 1 =>
Comment:
Thank you for the additional information. There are two bugs here.
(1) The games that are raising warnings have had their audio files
compressed by the ScummVM audio compression tool. The runtime code for
this had previously relied on hot patching volume file offsets at the
moment that a resource was loaded, instead of correcting file offsets when
reading audio maps. The code added for sanity checking audio volumes
started to report warnings because the offsets being received were for the
original uncompressed audio volume, which (naturally) is larger than the
compressed audio volume.
(2) Compressed audio volumes generated for KQ6 are missing Rave resources
(used for the portraits in high-resolution mode), so crash with the error
"could not translate offset to compressed offset in audio volume" when
trying to load Rave resources.
I have a patch for these issues that I plan to commit within the next day,
after additional testing. For the first problem, compressed audio volume
handling has been changed to translate offsets while resources are being
scanned and added. For the second problem, the validation code detects
that these resources are missing and prevents them from being added.
ScummVM will continue to (correctly) report that resource corruption is
detected, but the game will no longer crash when rendering portraits.
Please retrieve and use your original RESOURCE.AUD volume for this game.
--
Ticket URL: <https://bugs.scummvm.org/ticket/9764#comment:13>
ScummVM <https://bugs.scummvm.org>
ScummVM
More information about the Scummvm-tracker
mailing list