[Scummvm-tracker] [ScummVM] #10219: MOHAWK: Riven: Invalid read for RivenVideo::play/load

[dafioram]

#10219: MOHAWK: Riven: Invalid read for RivenVideo::play/load
---------------------+----------------------------
Reporter:  dafioram  |      Owner:  (none)
    Type:  defect    |     Status:  new
Priority:  normal    |  Component:  Engine: Mohawk
Keywords:            |       Game:  Riven
---------------------+----------------------------
 scummvm: 7a184f0e7fa0af7eca0518af6b46be09fcf25bdc
 Valgrind reports this when pressing the button to stop the spinning dome
 on prison island.
 I didn't notice any issues while playing.

 {{{
 ==24973== Invalid read of size 4
 ==24973==    at 0x36E90D:
 Audio::QuickTimeAudioDecoder::QuickTimeAudioTrack::seek(Audio::Timestamp
 const (quicktime.cpp:327)
 ==24973==    by 0x29F386:
 Video::VideoDecoder::SeekableAudioTrack::seek(Audio::Timestamp const&)
 (video_decoder.cpp:693)
 ==24973==    by 0x29E69B: Video::VideoDecoder::Track::rewind()
 (video_decoder.cpp:530)
 ==24973==    by 0x29DABC: Video::VideoDecoder::rewind()
 (video_decoder.cpp:323)
 ==24973==    by 0x1CC462: Mohawk::RivenVideo::play() (riven_video.cpp:276)
 ==24973==    by 0x1CC197: Mohawk::RivenVideo::playBlocking(int)
 (riven_video.cpp:219)
 ==24973==    by 0x1D11FC:
 Mohawk::RivenStacks::DomeSpit::runDomeButtonMovie() (domespit.cpp:48)
 ==24973==    by 0x1DAC13:
 Mohawk::RivenStacks::PSpit::xpscpbtn(Common::Array<unsigned short> const&)
 (pspit.cpp:105)
 ==24973==    by 0x1DB078: Common::Functor1Mem<Common::Array<unsigned
 short> const&, void,
 Mohawk::RivenStacks::PSpit>::operator()(Common::Array<unsigned short>
 const&) const (func.h:451)
 ==24973==    by 0x1C7FD2: Mohawk::RivenStack::runCommand(unsigned short,
 Common::Array<unsigned short> const&) (riven_stack.cpp:165)
 ==24973==    by 0x1C1B20:
 Mohawk::RivenSimpleCommand::runExternalCommand(unsigned short,
 Common::Array<unsigned short> const&) (riven_scripts.cpp:584)
 ==24973==    by 0x1C2EC9: Mohawk::RivenSimpleCommand::execute()
 (riven_scripts.cpp:794)
 ==24973==  Address 0x3de1c48c is 8 bytes after a block of size 20 alloc'd
 ==24973==    at 0x4C2E8BF: operator new[](unsigned long) (in
 /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
 ==24973==    by 0x3BE47E:
 Common::QuickTimeParser::readELST(Common::QuickTimeParser::Atom)
 (quicktime.cpp:438)
 ==24973==    by 0x3BD424:
 Common::QuickTimeParser::readDefault(Common::QuickTimeParser::Atom)
 (quicktime.cpp:232)
 ==24973==    by 0x3BD424:
 Common::QuickTimeParser::readDefault(Common::QuickTimeParser::Atom)
 (quicktime.cpp:232)
 ==24973==    by 0x3BDE6D:
 Common::QuickTimeParser::readTRAK(Common::QuickTimeParser::Atom)
 (quicktime.cpp:375)
 ==24973==    by 0x3BD424:
 Common::QuickTimeParser::readDefault(Common::QuickTimeParser::Atom)
 (quicktime.cpp:232)
 ==24973==    by 0x3BD575:
 Common::QuickTimeParser::readMOOV(Common::QuickTimeParser::Atom)
 (quicktime.cpp:258)
 ==24973==    by 0x3BD424:
 Common::QuickTimeParser::readDefault(Common::QuickTimeParser::Atom)
 (quicktime.cpp:232)
 ==24973==    by 0x3BCC72:
 Common::QuickTimeParser::parseStream(Common::SeekableReadStream*,
 DisposeAfterUse::Flag) (quicktime.cpp:104)
 ==24973==    by 0x298D00:
 Video::QuickTimeDecoder::loadStream(Common::SeekableReadStream*)
 (qt_decoder.cpp:68)
 ==24973==    by 0x1CB73C: Mohawk::RivenVideo::load(unsigned short)
 (riven_video.cpp:67)
 ==24973==    by 0x1C26BA:
 Mohawk::RivenSimpleCommand::activateMLST(Mohawk::MLSTRecord const&) const
 (riven_scripts.cpp:743)
 }}}

--
Ticket URL: <https://bugs.scummvm.org/ticket/10219>
ScummVM <https://bugs.scummvm.org>
ScummVM