[Scummvm-devel] Bug dumping scripts

[Luis]

Hi, first of all, I'm new to scummvm so the bug I've
found may not be a bug at all!!.
After dumping the scripts of Monkey 1 EGA, all of them
start with a 4-byte number that tells the size of the
script and after that they have 2 chars telling what
kind of script they are, but:

The entry and exit scripts seem to have two extra
bytes at the beginning, and running descumm3 tells me
the script type is unknown.

I've changed three lines in scummvm.cpp (see below)
and after that, the entry and exit scripts can be
disassembled without any problems.

The last changed line is only a bugfix on spelling :-)

--------------------------------------------------------------------------------

--- scummvm.cpp	Mon Jun 17 19:47:48 2002
+++ ../../cvs/scummvm/scummvm.cpp	Mon Jun 17 19:54:24
2002
@@ -551,8 +551,7 @@
 	if (ptr) {
 		_EXCD_offs = ptr - roomptr;
 #ifdef DUMP_SCRIPTS
-		dumpResource("exit-", _roomResource, ptr - 
-			(_features & GF_SMALL_HEADER ? 6 : 8));
+		dumpResource("exit-", _roomResource, ptr - 8);
 #endif
 	}
 
@@ -560,8 +559,7 @@
 	if (ptr) {
 		_ENCD_offs = ptr - roomptr;
 #ifdef DUMP_SCRIPTS
-		dumpResource("entry-", _roomResource, ptr -
-			(_features & GF_SMALL_HEADER ? 6 : 8));
+		dumpResource("entry-", _roomResource, ptr - 8);
 #endif
 	}
 
@@ -657,8 +655,7 @@
 			do {
 				char buf[32];
 				sprintf(buf, "room-%d-", _roomResource);
-				dumpResource(buf, id, ptr -
-					(_features & GF_SMALL_HEADER ? 6 : 8));
+				dumpResource(buf, id, ptr - 8);
 			} while (0);
 #endif
 			searchptr = NULL;
@@ -939,7 +936,7 @@
 		if (_sound_volume_master < 0)
 			_sound_volume_master = 0;
 		_imuse->set_master_volume(_sound_volume_master);
-	} else if (_lastKeyHit == 93) { // ], eg volume up
+	} else if (_lastKeyHit == 93) { // ], eg volume down
 		_sound_volume_master+=5;
 		if (_sound_volume_master > 128)
 			_sound_volume_master = 128;		
[



--------------------------------------------------------------------------------



Luis Parravicini


Cobertura especial de la Copa Mundial de la FIFA Corea-Japón 2002, sólo en Yahoo! Deportes:
http://ar.sports.yahoo.com/fifaworldcup/