[Scummvm-devel] Porting headaches

[Arisme]

----- Original Message -----
From: "Max Horn" <max at quendi.de>
To: "Arisme" <arisme at free.fr>
Cc: <scummvm-devel at lists.sourceforge.net>
Sent: Tuesday, December 09, 2003 12:35 AM
Subject: Re: [Scummvm-devel] Porting headaches



>
> Yuck! Seems EVC is seriously broken. This is perfectly legal C++ code
> <sigh>.
>

Just imagine Visual Studio 6 with more (and even different) bugs, and you
get it ...

btw it chokes on MKLINE(AudioManager::status, ...)  too, but that's not
really a problem ... I'm just defining a different OFFS macro for EVC ...

>
> I assume you mean changing the class names, not the method names? Or
> doesn't that hel?
>
> I am not happy about this, but if it helps to support some broken
> compiler w/o causing us too much pain, you may rename the
> Summ::OptionsDialog to something else.
>

I meant changing the method names in the Scumm namespace, I don't think
changing the class name would help.

Alternate lame quickfix (what I did in my local tree to test the current CVS
in fact), but perhaps it sounds better for you ? you may even provide a more
creative name for openEVC if you wish :)

in gui/options.cpp

#ifdef _WIN32_WCE
void OptionsDialog::openEVC()
        OptionsDialog::open()
}
#endif

in scumm/dialogs.cpp

#ifdef _WIN32_WCE
openEVC();
#else
GUI::OptionsDialog::open();
#endif