[Scummvm-devel] =?iso-8859-2?Q?Re:=A0CVS:=A0scummvm/scumm=A0imuse=5Fdigi.cpp=2C1.84=2C1.8?= 5�imuse_digi.h,1.23,1.24�script_v8.cpp,2.207,2.20 =?iso-8859-2?Q?Re:�CVS:�scummvm/scumm�imuse_digi.cpp,1.84,1.85=A0imuse?= _digi.h =?iso-8859-2?Q?=2C1.23=2C1.24=A0script=5Fv8.cpp=2C2.207=2C2.208=A0sound.c?= pp=?iso-8859-2?Q?=2C1.297=2C1.298=A0string.cpp=2C1.172=2C1.173?=

[pablo at omega.xtr.net.pl]

>
> Am Freitag, 26.12.03 um 13:15 Uhr schrieb Pawel Kolodziejski:
>
>> Update of /cvsroot/scummvm/scummvm/scumm
>> In directory sc8-pr-cvs1:/tmp/cvs-serv7221/scumm
>>
>> Modified Files:
>> 	imuse_digi.cpp imuse_digi.h script_v8.cpp sound.cpp string.cpp
>> Log Message:
>> passthrought v7+ sound voices by imuse digital
>>
> I don't object to the spirit of the change, but the way it was done
> seems quite evil to me. I really hope that this is just a temporary
> measure and proper code will be written soon.

yes, it's temporary code. i can't do huge change at once.

> In particular, this is quite revolting to me:
>
>> Index: imuse_digi.cpp
>>
>
> [...]
>>
>> +void IMuseDigital::setVocVoice(byte *src, int32 size, int rate) {
>> +	_voiceVocData = src;
>> +	_voiceVocSize = size;
>> +	_voiceVocRate = rate;
>> +}
>> +
>> +void IMuseDigital::setBundleVoice(byte *src) {
>> +	_voiceBundleData = src;
>> +}
>> +
> Essentially, class member variables are abused here as optional
> parameters. Quite evil and also error prone. Why not make them what
> they truly are: additional, optional parameters to startSound. Then you
> can completely get rid of those added class member variables.
startSound will be rewriten. now is temporary code.
>
> Regards,
>
> Max
>
>
>