[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/scumm sound.cpp,1.176,1.177

Hibernatus combel_t at epita.fr
Sat Jul 19 00:50:07 CEST 2003


I actually have checked it, there isn't any SO block with a bad waveSize in 
zak256. So if that error is ever triggered that means there is some serious 
problem. But anyway it's useless for the same reason why it's safe.

At 02:05 19/07/2003 -0500, J.Brown (Ender) wrote:
>Now, this is the type of fix that shoul probably NOT be commited during a
>freeze!
>
>Are we sure that this is never ever triggered anywhere in Zak256?
>This somewhat negates all the testing we have done to Zak up until this
>point, as it could potentially now cause a frozen considered 'stable' game
>from being completable.
>
>Whilst I agree that it is probably better to error() in this situation
>this should NOT have been commited without further discussion.
>
>Can I please get a guarantee this error  cannot possibly occur anywhere in
>Zak256? Otherwise please revert it ASAP.
>
>We will be branching on Monday/Tuesday, and this should probably be
>reverted until then.
>
>  - Ender
>
>    http://www.scummvm.org/   | "Amen! Attempts to eradicate humour from
>    http://www.quakesrc.org/  |  our distribution should be ignored with
>    http://www.enderboi.com/  |  extreme prejudice" - cjwatson at debian.org






More information about the Scummvm-devel mailing list