[Scummvm-devel] V2/3 music in scummvm.
Max Horn
max at quendi.de
Thu Jun 19 17:24:29 CEST 2003
The basic idea seems sound to me (no pun intended ;-). I admit I didn't
look now closely at the things involved here, but personally I fully
trust Jamieson and Jochen to handle this properly (of course I'll be
happy to join any design discussions if that's desirable).
IMHO the abstract interface and MidiPlayer should be in sound/ (they
are used by simon, too, AFAIK), while the various AD/WA/etc.
subclasses, being scumm specific, should reside in the scumm/ directory.
Finally, i wonder in how far we could also look into unifying the
IMuseDigital API a bit into this... I.e. right now we have either
Player_V2, iMuse, or iMuseDigital in effect. Their APIs are in many
ways similar, and in fact we have code like this:
if (_scumm->_imuseDigital)
return _scumm->_imuseDigital->getSoundStatus(sound);
if (_scumm->_imuse)
return _scumm->_imuse->getSoundStatus(sound);
if (_scumm->_playerV2)
return _scumm->_playerV2->getSoundStatus (sound);
Since the three are (AFAIK?) excluding each other (i.e. at most one of
them is used at a time), it would seem to make sense to have them
derived from a common abstract base class... I am not sure in how far
that would figure into your overall plans, though.
Cheers,
Max
More information about the Scummvm-devel
mailing list