[Scummvm-devel] Re: CVS: scummvm/scumm intern.h,2.117,2.118 sc ript _v6.cpp,1.205,1.206 script_v8.cpp,2.199,2.20

Pawel Kolodziejski pablo at omega.xtr.net.pl
Sun Nov 9 23:50:02 CET 2003


>
> Am Sonntag, 09.11.03 um 23:12 Uhr schrieb Pawel Kolodziejski:
>
>> Update of /cvsroot/scummvm/scummvm/scumm
>> In directory sc8-pr-cvs1:/tmp/cvs-serv7950
>>
>> Modified Files:
>> 	intern.h script_v6.cpp script_v8.cpp
>> Log Message:
>> renamed some opcodes and added sobopcode comments
>>
>
> 1) May I ask why these name changes? In a few cases I can see a logic
> behind it. In others, I am actually surprised by the changed. E.g. why
> was renamed o6_ifClassOfIs() to o6_getClass() ? The opcode doesn't
> "get" the actor class, after all - it checks if the actor is in any of
> the given classes. And the opcode name isn't in sync with the
> corresponding V5 opcode anymore. That seems illogical.
Right, it's should be o6_ifClassOfIs instead o6_getClass.

> 2) If you change opcode names, please always also update descumm!
> Otherwise, things get *very* confusing. Please fix that ASAP.
Sorry, I forgot about it :) I'll change that too. :)

>
> Cheers,
>
> Max
>
>
>





More information about the Scummvm-devel mailing list