[Scummvm-devel] Re: CVS: scummvm/scumm script_v2.cpp,2.211,2.2Re: CVS: scummvm/scumm script v2.cpp,2.211,2.212 script _v5.cpp ,1.206,1.207

Pawel Kolodziejski pablo at omega.xtr.net.pl
Mon Nov 10 03:28:04 CET 2003

> Am Montag, 10.11.03 um 10:16 Uhr schrieb Pawel Kolodziejski:
>> Update of /cvsroot/scummvm/scummvm/scumm
>> In directory sc8-pr-cvs1:/tmp/cvs-serv5808
>> Modified Files:
>> 	script_v2.cpp script_v5.cpp
>> Log Message:
>> added subopcode comments
> What do you mean, "added subopcode comments" ? You replaced clear
> english comments by cryptic ones. Who ever said that we have to use
> these "SO_FOO" constants ? They are nothing "official" in any way. So
> where is the point?

Some comments are before diffrent named between script versions, now is
more clear what is subcode. Better solution is replace constants value by
names opcodes. Source code is not good place for comments about what code
do (except hacks, something completly not clear). For this are docs
outside of source or at least outside func definition.

More information about the Scummvm-devel mailing list