[Scummvm-devel] New DEFAULT_SAVE_PATH in 0.7.0 ?

Max Horn max at quendi.de
Sat Dec 18 08:38:01 CET 2004


Am 18.12.2004 um 13:07 schrieb Jonathan Gray:

> Update of /cvsroot/scummvm/scummvm/base
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv13146/base
>
> Modified Files:
>       Tag: release-0-7-0
> 	gameDetector.cpp
> Log Message:
> Default *nix save path for 0.7.0 as well.

Hum, I am not sure if we really want to have that feature in 0.7.0, 
it's a bit hasty to add it so shortly before the release and all.

For example, the code you inserted to handle the save dir isn't quite 
safe: it doesn't check that DEFAULT_SAVE_PATH is actually pointing to a 
writable directory.

Also, this is a behavior change: anybody who so far used scummvm w/o an 
explicitly set savepath won't be able to load their savegames anymore. 
Hence, at the very least this new feature should be documented in the 
README before we put it in a full blown release!



Bye,

Max





More information about the Scummvm-devel mailing list