[Scummvm-devel] Re: CVS: scummvm/scumm akos.cpp,1.90,1.91

Max Horn max at quendi.de
Fri Jan 2 06:40:04 CET 2004


Am 02.01.2004 um 05:58 schrieb Travis Howell:

> Update of /cvsroot/scummvm/scummvm/scumm
> In directory sc8-pr-cvs1:/tmp/cvs-serv27026/scumm
>
> Modified Files:
> 	akos.cpp
> Log Message:
>
> Fix missing sfx in puttputt
>
>
Did you check whether this doesn't cause regressions? See also akos.cpp 
revision 1.30 comment: "added missing sound effects based on patch 
#654463".

In general, I would recommend first checking why a certain 
fix/change/hack was made before undoing it. Then, once you know the 
reason, check if your undoing of the fix doesn't cause the issue which 
was originally fixed to reappear... maybe you did that, but it's not 
clear from this commit...


Max





More information about the Scummvm-devel mailing list