[Scummvm-devel] Re: CVS: scummvm/scumm intern.h,2.122,2.123 script_v6.cpp,1.234,1.235

Max Horn max at quendi.de
Fri Jan 2 07:34:44 CET 2004


Am 02.01.2004 um 15:53 schrieb Travis Howell:

> Max Horn wrote:
>> Am 02.01.2004 um 14:21 schrieb Travis Howell:
>>
>>> Update of /cvsroot/scummvm/scummvm/scumm
>>> In directory sc8-pr-cvs1:/tmp/cvs-serv1962/scumm
>>>
>>> Modified Files:
>>> intern.h script_v6.cpp
>>> Log Message:
>>>
>>> Add another HE games opcode and case.
>>>
>> Hmm, I really would appreciate if all the HE specific opcodes would be
>> marked with at least a comment stating that they are HE specific. Even
>> better, why not introduce a ScummEngine_V6HE class?
>
> I think all the 'file operations' related opcodes are HE specific but 
> not
> completely sure.
> Would it be worth adding extra class ? so far HE games only add 'file
> operation' specific opcodes and a few other minor changes.
>
Adding an extra class costs little. But it allows us to separate HE 
specific stuff a bit better from the rest. Which is IMO a good thing to 
do. It may very well come in handy at some point.


Cheers,

Max





More information about the Scummvm-devel mailing list