[Scummvm-devel] [PATCH] Alsa sequencer backend

[Christian Schoenebeck]

Es geschah am Dienstag, 27. Juli 2004 15:35 als Jonathan Gray schrieb:
> > 	* scummvm doesn't exit if can't subscribe to another Alsa seq client,
> > insted an error message is shown and the user has the chance to connect
> > manually (e.g. with aconnect or within his favorite sequencer
> > application)
>
> You misunderstand the code, error() is fatal (the return statement
> should not have been there).  I don't really see how this would work
> anyway. Besides this should be reported on launching ScummVM so its not
> really a great hassle for the user to have to start again.

Yeah, I didn't notice that error() quits the application. But IMO this is not 
an error of 'fatal' category and thus an error message on the console should 
be sufficient. There's still aconnect and aconnect-gui and various other alsa 
seq managers that allow to connect the alsa seq client with another one at 
runtime.

> I applied the patch with some syntax nits/hand merging and shortened the
> error string.  In addition to acconnect/SCUMMVM_PORT alsa_port can also
> be specified in the config file however we don't really need to
> enumerate these, especially considering the user probably specified a
> port already at this point.  The error string in your patch was
> already several lines long which was overlapping parts of the readme.

I know, but it's more convenient for the user, so he doesn't have to look at 
the docs. Anyway, at least there's now a pointer to the README.

Btw I did not notice that there's an environment variable 'SCUMMVM_PORT' until 
I looked on the code. Environment variables should be listed on the man page!

Thanks!

CU
Christian