[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/simon simon-md5.h,NONE,1.1 intern.h,1.30,1.31 simon.cpp,1.439,1.440 sound.cpp,1.66,1.67

[Max Horn]

Am 30.07.2004 um 11:00 schrieb Travis Howell:

> Update of /cvsroot/scummvm/scummvm/simon
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29916/simon
>
> Modified Files:
> 	intern.h simon.cpp sound.cpp
> Added Files:
> 	simon-md5.h
> Log Message:
>
> Reduce simon 1/2 targets
> Add auto detection
>

[...]

>
> @@ -61,21 +63,24 @@
>
>  static const SimonGameSettings simon_settings[] = {
>  	// Simon the Sorcerer 1 & 2 (not SCUMM games)
> -	{"simon1acorn", "Simon the Sorcerer 1 (Acorn)", GAME_SIMON1ACORN, 
> "DATA"},
> +	{"simon1acorn", "Simon the Sorcerer 1 (Acorn)", GAME_SIMON1ACORN, 
> "GAMEBASE"},
>  	{"simon1dos", "Simon the Sorcerer 1 (DOS)", GAME_SIMON1DOS, 
> "GAMEPC"},
>  	{"simon1amiga", "Simon the Sorcerer 1 (Amiga)", GAME_SIMON1AMIGA, 
> "gameamiga"},
>  	{"simon2dos", "Simon the Sorcerer 2 (DOS)", GAME_SIMON2DOS, 
> "GAME32"},
> -	{"simon1talkie", "Simon the Sorcerer 1 Talkie (DOS)", 
> GAME_SIMON1TALKIE, "SIMON.GME"},
> -	{"simon2talkie", "Simon the Sorcerer 2 Talkie (DOS)", 
> GAME_SIMON2TALKIE, "GSPTR30"},
> -	{"simon1win", "Simon the Sorcerer 1 Talkie (Windows)", 
> GAME_SIMON1WIN, "SIMON.GME"},
> +	{"simon1talkie", "Simon the Sorcerer 1 Talkie", GAME_SIMON1TALKIE, 
> "GAMEPC"},
> +	{"simon2talkie", "Simon the Sorcerer 2 Talkie", GAME_SIMON2TALKIE, 
> "GSPTR30"},
>  	{"simon1cd32", "Simon the Sorcerer 1 Talkie (Amiga CD32)", 
> GAME_SIMON1CD32, "gameamiga"},
> -	{"simon2win", "Simon the Sorcerer 2 Talkie (Windows)", 
> GAME_SIMON2WIN, "GSPTR30"},
> -	{"simon2mac", "Simon the Sorcerer 2 Talkie (Amiga or Mac)", 
> GAME_SIMON2MAC, "simon2.dic"},
>  	{"simon1demo", "Simon the Sorcerer 1 (DOS Demo)", GAME_SIMON1DEMO, 
> "GDEMO"},
>
>  	{NULL, NULL, 0, NULL}
>  };
>

Auto-detection is fine, but lack of any upgrade strategy seems like a 
bad idea to me. So anybody using the simon2mac, simon2win or simon1win 
targets in their config file now has bad config entries. Worse, without 
manually editing the config file, there is no way for them to fix it; 
so one has to re-add those entries. Of course that's possible, but it'd 
be sooo much nice if a smooth transition was enabled.

At the very least, instead of just exiting, print a message which tells 
people to manually update their config file. That also means telling 
people which targets they should use instead now.

Or still allow the old target names, but print a "deprecated" message.

Or automagically update those targets: if for example a "simon2mac" 
target is loaded (i.e. a target with that gameid), automatically update 
its gameid value to whatever now is the appropriate gameid (actually, I 
have no idea what that is...



Bye,

Max