[Scummvm-devel] Features and graphics modes

[Max Horn]

Am 13.03.2004 um 16:10 schrieb Marcus Comstedt:

>
> Max Horn <max at quendi.de> writes:
>
>> The problem is that it's near impossible to define what is "default"
>> for all given backends. And not all backends will want to add
>> "default" to the list of their scalers (e.g. for the SDL backend this
>> wouldn't make sense).
>>
>> I guess a "proper" fix for this might be to define a special
>> "kDefaultScalerMode" or whatever constant, which then can be passed to
>> setGraphicsMode, i.e. setGraphicsMode() could be changed to
>> setGraphicsMode.
>>    if (mode == "default")
>>       setGraphicsMode(kDefaultScalerMode);
>>    else ..
>
>
> Either that, or simply require that the first mode in the list
> returned by getSupportedGraphicsModes() is the "default" one:
>
>   if (mode == "default")
>      setGraphicsMode(gm[0].id);
>   else ...
>
That's kind of abuse, though, and not better than the current abuse - 
for example, in the SDL backend the scalers are "logically" sorted, I 
wouldn't want to change that just so we can save 5 lines of code :-)


Cheers,

Max