[Scummvm-devel] Re: CVS: scummvm/base main.cpp,1.55,1.57

[Eugene Sandulenko]

Max Horn writes:
 > There are more solutions, actually. Like, we could remove the above 
 > "illegal" methods from the respective init() methods. In the case of 
 > SMUSH playback, for example, that shouldn't be started by init() yet. I 
 > moved our savegame loading to go() for this reason.
Yes, that's more correct solution.

 > I don't know what you mean with adding "initGfx", what would that 
 > method do ?
I just forgot about go() method :). What I meant that it will contain
all required graphics setup and will be guaranteely run inside of
transaction. 

May you fix SCUMM engine? I could commit current code which does no
transactions, but keeps transaction states. It breaks most of the
engines, but you clearly may see what should be moved. If I'll commit,
we should fix it asap.

An example of FT run:

Assertion failed: (_transactionMode == kTransactionNone), function setShakePos, file backends/sdl/graphics.cpp, line 853.

BTW, may you mention in documentation to Engine::init() that it will
be run inside of OSystem transaction, and that some methods will not
work?


Eugene