[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/sound mixer.cpp,1.185,1.186 mixer.h,1.98,1.99

[Torbjorn.E.Andersson at personec.com]

Fingolfin wrote:

> Simplified SoundHandle implementation

I think this change is causing regressions in Broken Sword II. It used to
be that I could declare a PlayingSoundHandle and immediately call
isActive() in it, because it was automagially initialized to a non-active
sound handle. Now, as I understand it, an uninitialized SoundHandle is
undefined, and isSoundHandleActive() could return anything.

This is a problem because BS2 currently uses that function not just to ask
"am I still playing?" but also to ask "have I even begun playing yet?"

Of course this can be worked around. But I wanted to raise the issue here
first because I may be missing something obvious. And if I'm not, it may
affect other engines as well.

Torbjörn

-- 
Personec AB
Torbjörn Andersson, Systemutvecklare

Phone: +46 (0)533 68 35 75
Fax: +46 (0)533 68 35 33, email: torbjorn.e.andersson at personec.com
www.personec.com
Visiting address: Järnvägsgatan 11
Post address: Järnvägsgatan 11, S-661 31 Säffle, Sweden

Personec: 100% HR
Part of TietoEnator

Please note: The information contained in this message may be legally
privileged and confidential and protected from disclosure. If the reader of
this message is not the intended recipient, you are hereby notified that any
unauthorised use, distribution or copying of this communication is strictly
prohibited. If you have received this communication in error, please notify
us immediately by replying to the message and deleting it from your
computer. Thank you.