[Scummvm-devel] Re: [ScummVM] CVS: scummvm/kyra kyra.cpp,1.59,1.60 kyra.h,1.27,1.28 screen.cpp,1.14,1.15 screen.h,1.10,1.11 staticres.cpp,1.11,1.12

[James 'Ender' Brown]

Please redirect comments on CVS commits to -devel, since there are
several cvs commit lists (mine and the SF one) :)

 - Ender


On Sat, 2005-10-22 at 10:04 +0200, Gregory Montoir wrote:
> Johannes Schickel wrote:
> > Update of /cvsroot/scummvm/scummvm/kyra
> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6978
> > 
> > Modified Files:
> > 	kyra.cpp kyra.h screen.cpp screen.h staticres.cpp 
> > Log Message:
> > Implemented correct cursor handling.
> > 
> 
> Some remarks :
> - your code isn't endian safe. Try to use the macros directly when you
> are writing code ; it makes the work easier for the porters.
> - try to rename variables/functions with meaningful names (ie. no var1,
> var2, helper...). I know that's not always easy, but I think it's
> important to do it. The names in the .idb are not set in stone, you can
> (should?) change them.
> - apparently, you added some code which handle all the hide/show mouse
> stuff in the engine ; like the original engine did. I don't think you
> should do that, the OSystem interface already handles all that nicely.
> - any reason you didn't rename decodeShape() to encodeShape() ?
> 
> Other than that, good work ;)
-- 
James 'Ender' Brown <ender at scummvm.org>