[Scummvm-devel] kMD5FileSizeLimit = 1024 * 1024

Marcus Comstedt marcus at mc.pp.se
Sun Aug 6 15:12:44 CEST 2006


Jamieson Christian <jamiesonc at tds.net> writes:

>[...] (Do we 
> take into account total file size when fingerprinting? Should we?)

I think we certainly should.  If the size is wrong, we don't need to
md5 (or even open) the file at all to determine if it's a match or
not, so checking the size first would be much faster than not doing
it.  I believe the FileSystem API is lacking a file size API though.
Maybe a new ListMode to get sizes with the files?


  // Marcus






More information about the Scummvm-devel mailing list