[Scummvm-devel] START_PACK_STRUCTS default changed -- portbreakage

[Chris Apers]

The FT bug is very interesting since this is the problem with PalmOS version
for a long time. 

This change should also break the Gob engine, can someone confirm this?

I agree with you regarding use of non packed structs, this should fix
Lots of PalmOS problem, but as you said it will be a lot of work

Chris

-----Message d'origine-----
De : scummvm-devel-bounces at lists.sourceforge.net
[mailto:scummvm-devel-bounces at lists.sourceforge.net] De la part de Torbjörn
Andersson
Envoyé : samedi 22 juillet 2006 18:47
À : scummvm-devel at lists.sourceforge.net
Objet : Re: [Scummvm-devel] START_PACK_STRUCTS default changed --
portbreakage

Max Horn wrote:

> My next change will be to remove GCC_PACK (assuming my testings for  
> that turn up positive).

Unfortunately, this change causes regressions. I know LordHoto already
fixed one (the size of the SCUMM engine's SaveInfoSection changed from
26 to 28 when the packed attribute was removed, causing new savegames to
be broken). The only other I'm aware of is that Full Throttle crashes
when punching your way out of the dumpster at the very start of the
game. I assume there are other problems as well, which will have to be
solved on a case-by-case, or should I say struct-by-struct, basis.

My guess - the documentation isn't entirely clear to me - is that the
#pragma only affects the alignment of the struct members, while the
attribute packs it to the smallest possible size.

Mind you, I was not aware of any problems with this until after the
change had been made. Removing dependencies on GCC features seems like a
good thing to me. Actually, I wouldn't mind if we didn't use packed
structs at all, but I know that's a lot of work.

Torbjörn

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Scummvm-devel mailing list
Scummvm-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scummvm-devel