[Scummvm-devel] 0.9.0: Oops! Missing clipping in about dialog...

[Marcus Comstedt]

Johannes Schickel <lordhoto at gmail.com> writes:

> I just checked the code, but it should clip all stuff (check
> NewFont::drawChar, ThemeClassic::restoreBackground and
> ThemeClassic::addDirtyRect), also I used valgrind and I didn't get any
> warning. So maybe you should track it down and tell us the real problem.
> (I tried Classic theme in 320x200, which is used for Dreamcast as far as
> I saw it...)

Actually, I followed your advice and took a quick look at
NewFont::drawChar(), and I think I _can_ tell you the real problem.
The clipping code is there but it is all wrong.  The code _draws_ at

  ty + desc.ascent - bby - bbh + y

but checks

  ty + y

against the screen size.  So it can draw (desc.ascent-bby-bbh) pixels
outside the screen.


  // Marcus