[Scummvm-devel] Simplifying keyboard repeat

Max Horn max at quendi.de
Sun Sep 24 15:39:31 CEST 2006


Am 03.06.2006 um 21:24 schrieb Torbjörn Andersson:

> So did we reach any sort of conclusion about this? One way or the  
> other,
> it would be nice (but far from necessary) to have keyboard repeat  
> in the
> Simon engine for 0.9.0. I do have a patch for adding that the "old"  
> way
> which I could use, or there's the backend change which may already be
> too late for 0.9.0 anyway.
>
> Or some completely new, yet to be determined way.
>
> Torbjörn Andersson

The last I saw on that subject (at least I didn't find any replies to  
it when I looked through my mail archive) was this:


Am 19.05.2006 um 09:53 schrieb Max Horn:

[...]

> So keyboard access is available at least for the DC, some SDL  
> ports, and the X11 port.
>
> The original question on this thread was keyboard repeat.  
> Implementing keyboard repeat in a platform independent way is what  
> the GUI code currently tries to do, with mixed success. As David  
> Given pointed out, this may cause problems on e.g. X11.
> So, the natural way to handle this is to use the native keyboard  
> repeat when available, and to emulate it otherwise. To this end, we  
> could either add a kFeatureKeyboardRepeat flag. Or, we could  
> *require* backends to implement/emulate keyboard repeat, but  
> provide the code required for that. Maybe it would even be possible  
> to add the code require for that directly into OSystem, thus  
> letting porters implement this with a minimal amount of work.
>
> The latter approach has the nice benefit that it would require the  
> least changes to client code. With the former, we'd have to change  
> all event loops to use some kind of new encapsulation API.



I still would do it that way. But let's see whether there are any  
objections.


Bye,
Max



More information about the Scummvm-devel mailing list