[Scummvm-devel] iMuse Digital questions

[Max Horn]

Hi folks,

I recently was looking at the iMuse Digital stuff and was wondering  
about some bits. Maybe aquadran or somebody else with a good IDB for  
COMI (and "The Dig", for that matter) can help a bit!

First off, I noticed that IMuseDigital::setDigMusicSequence and  
setComiMusicSequence (in engines/scumm/imuse_digi/dimuse_music.cpp)  
are very similar to each other, with some very subtle differences.  
Some of them (modifications made to the _attributes array), I  
understand. But for some of the others, I wonder whether those are  
really differences, or maybe small mistakes we made during  
disassembling. So, maybe could verify that our code is correct -- I  
placed FIXMEs in the relevant code near the spots that differ.

Next, in playDigMusic, there is a call to fadeOutMusic(120) just  
before the switch/case; in playComiMusic, it is there, too, but  
inside case 0 of the corresponding switch/case. Correct translation?

Lastly, there is bug #1861099 by Torbjörn which implies that we are  
not handling music transitions quite correctly. So it might be worth  
checking our code some more in this regard. <https://sourceforge.net/ 
tracker/?func=detail&atid=418820&aid=1861099&group_id=37116>


Chees,
Max